siavash79 / PixelXpert

mixed Xposed+Magisk module for customization of Google Pixel rom of Android 12+
GNU General Public License v3.0
1.81k stars 111 forks source link

[Bug] Signal Icons Theme (non-default) causes .gms.persistent logcat spam #427

Closed hyproman closed 1 year ago

hyproman commented 1 year ago

Describe the issue

Enabling a non-default Themes->Signal Icons Theme setting causes .gms.persistent logcat error spam; I/O error reading the APK(s) of the enabled theme. For example, with Xperia theme enabled, the log messages are:

E .gms.persistent: Failed to open APK '/product/overlay/AOSPMods_XperiaSignal/XperiaSignalOverlay.apk': I/O error E .gms.persistent: Failed to open APK '/product/overlay/AOSPMods_XperiaWiFi/XperiaWiFiOverlay.apk': I/O error.

These messages repeat many many times per "event", where each "event" depends on user interaction with the phone (presumably related to status bar icon updates? Unclear). Selecting the default icon theme mutes these errors.

Steps to reproduce

  1. Start tailing the log for errors: adb logcat '*:S .gms.persistent'
  2. Open AOSPMods, navigate to Themes -> Signal Icons Theme, and choose a theme (I have tried Xperia and Sneaky so far; both have reproduced the issue)
  3. Close AOSPMods and navigate around the phone a little (if all else fails, load Google Maps, but this is not required)
  4. Observe logcat output, spamming many error messages regarding "I/O error" trying to read from "/product/overlay/AOSPMods_/"

Expected bahavior

Expected no logcat error messages, as is such when running with no Signal Icons Theme enabled.

Your device setup (Please take some time to give correct information here)

Other Magisk Modules Enabled:

Logs

No response

hyproman commented 1 year ago

Curious observation: without theming enabled, at least when Location Services is being used (e.g. Google Maps open), there exists a Location status bar icon. However, with theming enabled, no themed Location status bar icon is visible. Could it be that the theme apks do not contain a Location icon, and that is what Google's location services is complaining about? Unclear to me.

EleoXDA commented 1 year ago

Describe the issue

Enabling a non-default Themes->Signal Icons Theme setting causes .gms.persistent logcat error spam; I/O error reading the APK(s) of the enabled theme. For example, with Xperia theme enabled, the log messages are:

E .gms.persistent: Failed to open APK '/product/overlay/AOSPMods_XperiaSignal/XperiaSignalOverlay.apk': I/O error E .gms.persistent: Failed to open APK '/product/overlay/AOSPMods_XperiaWiFi/XperiaWiFiOverlay.apk': I/O error.

These messages repeat many many times per "event", where each "event" depends on user interaction with the phone (presumably related to status bar icon updates? Unclear). Selecting the default icon theme mutes these errors.

Steps to reproduce

  1. Start tailing the log for errors: adb logcat '*:S .gms.persistent'
  2. Open AOSPMods, navigate to Themes -> Signal Icons Theme, and choose a theme (I have tried Xperia and Sneaky so far; both have reproduced the issue)
  3. Close AOSPMods and navigate around the phone a little (if all else fails, load Google Maps, but this is not required)
  4. Observe logcat output, spamming many error messages regarding "I/O error" trying to read from "/product/overlay/AOSPMods_/"

Expected bahavior

Expected no logcat error messages, as is such when running with no Signal Icons Theme enabled.

Your device setup (Please take some time to give correct information here)

  • Google Pixel 6 Stock Firmware Build TPA.221005.002
  • Android 13
  • AOSPMod (Full) canary-162
  • LSPosed 1.8.4
  • Magisk 25.2 stable
  • Zygist enabled; enforcing DenyList (to pass SafetyNet, Play Protect, etc)

Other Magisk Modules Enabled:

  • Advanced Charging Controller
  • Busybox for Android NDK
  • CloudflareDNS4Magisk
  • Magiskhide Props Config
  • NoStorageRestrict
  • Systemless Hosts
  • Universal SafetyNet fix
  • Zygist - LSPosed

Logs

No response

You report log spam without sharing logs. Please share logs. Those are vital especially when we cannot replicate your issue

EleoXDA commented 1 year ago

Curious observation: without theming enabled, at least when Location Services is being used (e.g. Google Maps open), there exists a Location status bar icon. However, with theming enabled, no themed Location status bar icon is visible. Could it be that the theme apks do not contain a Location icon, and that is what Google's location services is complaining about? Unclear to me.

Themes and icon packs included in AOSPMods are not maintained anymore. They are presented in "AS IS" basis

If you like it, use it. But there may be no support regarding them

hyproman commented 1 year ago

@EleoXDA So can you reproduce it or not?

I looked at the LSPosed logs, and they don't say anything interesting. I listed the magisk modules I'm running; I hope you'd agree that none of them have anything to do with UI theming or anything remotely related. Also literally the only reason I have LSPosed is for AOSPMods.

Given your comment and the fact that you've already closed this bug (which is fine by me; I'm very happy with AOSPMods otherwise) then there's certainly no point in me jumping through hoops to provide more information, correct?

Anyway, thanks for your time and effort. This module makes A12+ manageable.

EleoXDA commented 1 year ago

@EleoXDA So can you reproduce it or not?

I looked at the LSPosed logs, and they don't say anything interesting. I listed the magisk modules I'm running; I hope you'd agree that none of them have anything to do with UI theming or anything remotely related. Also literally the only reason I have LSPosed is for AOSPMods.

Given your comment and the fact that you've already closed this bug (which is fine by me; I'm very happy with AOSPMods otherwise) then there's certainly no point in me jumping through hoops to provide more information, correct?

Anyway, thanks for your time and effort. This module makes A12+ manageable.

The reason I closed this is because you say you observe something in logs whilst disregarding 10 seconds of extracting logs from lsposed to share here

Logs are the heart of the bugreport and no. I cannot reproduce it on my pixel 6 and 3aXL

So basically without logs we need to catch an invisible monster that you say is present.

"Jumping through hoops"? Really? Extracting logs from LSposed only takes 10 or less seconds. You open LSposed, you click to logs icon, click to save button on top => voila