Add option to remove icon for UDFPS hint

[aaronjamt]

Similar to the option to remove the background circle for it, this one instead removes the actual fingerprint icon. This allows you to visually hide that you have an UDFPS, if desired, or just remove the icon for a cleaner look.

I'm not sure how adding new translations are handled here so I only added English translations as that is the language I speak. If there is some other protocol involved in adding the translations, I'd be happy to follow it.

[aaronjamt]

Here is how it currently looks, and how it will look with the setting disabled:

Here is how it will look with the setting enabled:

[aaronjamt]

Note that, in both cases, UDFPS is active and functions normally. Disabling the background circle and the foreground icon do not prevent UDFPS from unlocking the device, they only act as a visual indicator to the user as to where to place their finger.

[EleoXDA]

Note that, in both cases, UDFPS is active and functions normally. Disabling the background circle and the foreground icon do not prevent UDFPS from unlocking the device, they only act as a visual indicator to the user as to where to place their finger.

Still do not understand the reason behind hiding UDFPS icon. Is it to make unlocking harder? Unless you know someone that has same FP as you, hiding it won't make difference afaik.

And it also doesn't disable the strong light that comes up from behind UDFPS when you want to unlock phone. With your mod it just would be harder to locate the exact region to where to hold the finger in so that it blasts less light outside...

[aaronjamt]

Still do not understand the reason behind hiding UDFPS icon. Is it to make unlocking harder?

If someone takes your phone, yes, that's one reason

Unless you know someone that has same FP as you, hiding it won't make difference afaik.

It makes it one more step and also makes it less likely for people to use up all your fingerprint attempts to force you to enter pin (that's happened to me several times, I'm a high school student and one of my classes requires that students put their phones in the middle of the table, where everyone else can try to guess your pin)

And it also doesn't disable the strong light that comes up from behind UDFPS when you want to unlock phone. With your mod it just would be harder to locate the exact region to where to hold the finger in so that it blasts less light outside...

Correct, although after using this phone for a couple years I can reliably place my finger in the correct spot, even with the phone in my pocket. I assume other people will also grow similarly accustommed to the UDFPS location on their devices as well. I built the code in this PR and have been using it on my phone since I opened this PR and have not found it any more diffficult to use.

Maybe this is a niche feature, but since it's toggleable, I see no reason not to add it as an option for those who wish to use it. Additionally, you could leave the background circle visible and just hide the fingerprint icon, which would still tell you where the UDFPS is, without the icon. I can imagine a minimalistic lock screen setup with just basic shapes and no icons, where that might be useful, for instance.

[EleoXDA]

Still do not understand the reason behind hiding UDFPS icon. Is it to make unlocking harder?

If someone takes your phone, yes, that's one reason

Unless you know someone that has same FP as you, hiding it won't make difference afaik.

It makes it one more step and also makes it less likely for people to use up all your fingerprint attempts to force you to enter pin (that's happened to me several times, I'm a high school student and one of my classes requires that students put their phones in the middle of the table, where everyone else can try to guess your pin)

And it also doesn't disable the strong light that comes up from behind UDFPS when you want to unlock phone. With your mod it just would be harder to locate the exact region to where to hold the finger in so that it blasts less light outside...

Correct, although after using this phone for a couple years I can reliably place my finger in the correct spot, even with the phone in my pocket. I assume other people will also grow similarly accustommed to the UDFPS location on their devices as well. I built the code in this PR and have been using it on my phone since I opened this PR and have not found it any more diffficult to use.

Maybe this is a niche feature, but since it's toggleable, I see no reason not to add it as an option for those who wish to use it. Additionally, you could leave the background circle visible and just hide the fingerprint icon, which would still tell you where the UDFPS is, without the icon. I can imagine a minimalistic lock screen setup with just basic shapes and no icons, where that might be useful, for instance.

Personally, I say no to this. I don't think there is any use of this mod outside your usage. And unfortunately, knowing some users, I am sure there will be at least 100s of bugreports saying "I can no longer see my FPS icon! Your mod broke it! Fix it ASAP!" after toggling on your mod and forgetting about it.

Don't worry. You still can fork the repo (as you already have) and create a separate PixelXpert module with your tweak.

But we'll hear more from Siavash when he is back. Maybe he can agree to this

[siavash79]

If it was me, I wouldn't add this option. But since you've already done it yourself nicely...... more contributions will be welcome too

[aaronjamt]

If it was me, I wouldn't add this option. But since you've already done it yourself nicely...... more contributions will be welcome too

Thank you for the merge!