siavash79 / PixelXpert

mixed Xposed+Magisk module for customization of Google Pixel rom of Android 12+
GNU General Public License v3.0
1.75k stars 107 forks source link

"Force AOD while charging" only takes effect under specific conditions #846

Closed b02860de585071a2 closed 3 months ago

b02860de585071a2 commented 3 months ago

Describe the issue

When "force AOD while charging" is enabled, it will not take effect unless SystemUI is restarted WHILE CHARGING. Restarting SystemUI/the device without a power source has no effect.

Steps to reproduce

  1. Enable "force AOD while charging"
  2. Restart SystemUI (or device) while on battery
  3. Plug in device, see no change in behavior
  4. Restart SystemUI again while still connected to power
  5. Observe expected behavior

Expected behavior

AOD should not require a SystemUI restart while actively charging.

Your device setup (Please take some time to give correct information here)

I have tested and replicated this behavior on stock Android 13 and 14, as well as LineageOS (currently using) and a handful of AOSP-based ROMs.

I understand that custom ROMs are not technically supported, I just want to provide more context. Clean flashing the latest stock A14 does not fix the bug (I tried).

magisk-1 magisk-2 magisk-3 lsposed

Logs

I rebooted, confirmed the unwanted behavior, restarted SystemUI (still unwanted behavior), then began charging and restarted SystemUI again (correct behavior).

LSPosed_2024-05-30T16_36_44.071326.zip

b02860de585071a2 commented 3 months ago

For what it's worth, I have tried resetting PixelXpert to defaults and only enabling the "force AOD while charging" option.

This had no effect, so I do not believe it's an interaction with any other setting. Maybe this helps save some debugging time.

siavash79 commented 3 months ago

Bug report from custom ROM is not acceptable. Closing

b02860de585071a2 commented 3 months ago

Bug report from custom ROM is not acceptable. Closing

Again, this occurs on bone stock Android 13-14 as well. I flashed back to May stock firmware last week and confirmed the same behavior.

Do I really have to flash back again and reopen? That seems unnecessary.

b02860de585071a2 commented 3 months ago

I have time tonight.

Here are logs from a completely fresh clean flash of A14 (AP1A.240505.005) on the same P8P, done with full factory images. Device was factory reset and stock firmware flashed on BOTH slots prior to this.

Logs captured with literally nothing installed, besides Magisk + the required modules to run PixelXpert. Exact same issue.

Magisk 27.0 LSPosed 1.9.2 PixelXpert canary 360

LSPosed_2024-06-02T22_34_43.385079.zip