search

sibalzer / impfbot

Benachrichtigungs-Bot für das niedersächische Impfportal / Notification bot for the lower saxony vaccination portal https://impfportal-niedersachsen.de
GNU General Public License v3.0
36 stars 8 forks source link

Printing of settings with a list value misses a delimiter #119

Closed andy71 closed 3 years ago

andy71 commented 3 years ago

When printing the settings, every list value is just a concatenated string of the list entries, without any delimiter.

Please replace this part of the code within settings.py with a simple join...

                if isinstance(value, list):
                    value = ', '.join(value)
#                    list_str = ""
#                    for entry in value:
#                        list_str += str(entry)
#                    value = list_str

The line behind the "isinstance" is the new one. Old lines which should be deleted are commented out.

andy71 commented 3 years ago

I added a pull request #120 to this.

Am I correct in assuming that a pull request or an issue is sufficient, but not both?

paulypeter commented 3 years ago

Am I correct in assuming that a pull request or an issue is sufficient, but not both?

Writing both is fine! You followed the usual procedure, which is:

  1. If you notice a bug or have a feature request, you open an issue detailing it. If you want to fix it yourself or have an idea on how to do so, you can say so in the issue. If not, that's fine as well!
  2. If you do want to fix it, you fork the repo and implement your solution there.
  3. You create a pull request from your repo to the upstream repo.

For a better overview, it is not recommended to open a pull request without having a corresponding issue.

sibalzer commented 3 years ago

closed with #120, thanks