search

sibartlett / Geo

A geospatial library for .NET
https://www.nuget.org/packages/Geo/
GNU Lesser General Public License v3.0
176 stars 39 forks source link

Improve GPX compatibility #45

Closed sibartlett closed 4 years ago

sibartlett commented 4 years ago
sibartlett commented 4 years ago

@mfeingol please take a look :)

mfeingol commented 4 years ago

Thanks, @sibartlett, these changes look great!

The commit is very similar to a commit I started but stashed away, because the changes seemed too extensive to justify from my particular need. But I think ultimately this is the right thing to do, and it makes sense to make all breaking changes in a single version increment.

Thanks again.

sibartlett commented 4 years ago

What .NET version are you using @mfeingol ?

Wondering if it's worth migrating the library to nullable reference types, seeing that this will be a whole new version?

mfeingol commented 4 years ago

Personally I'm using Geo with UWP (.NET Core 2.2) And Xamarin Forms for Android (Mono).

That said, I don't think it matters. My understanding is that you can enable this feature for a library and continue to emit assemblies for versions older than .NET Standard 2.1, simply by using C# 8.0 in your project and continuing to multi-target.

I have yet to start using nullable reference types in a large project, but it seems like a really good idea.

https://devblogs.microsoft.com/dotnet/embracing-nullable-reference-types/ https://stackoverflow.com/questions/56651472/does-c-sharp-8-support-the-net-framework