sibartlett / homebridge-wink3

Homebridge plugin for wink.com
https://sibartlett.github.io/homebridge-wink3
ISC License
53 stars 20 forks source link

Add Config.schema.json/ Update Dependencies #131

Closed AppleTechy closed 4 years ago

AppleTechy commented 4 years ago

Changes included: 1) Add Config.schme.json

2) Updated Dependencies

3) Bumped plugin version number from "2.1.0", to "2.1.1".

*With the announcement Wink made yesterday I am assuming this will probably be the last ever update needed.

sibartlett commented 4 years ago

I merged everything, except:

I may merge them in later... but I spent a fair bit of time cleaning the commits up, and wanted to get a new version published ASAP.

New package is published as 3.0.0 - as I had to drop support for node 8.

AppleTechy commented 4 years ago

Sounds good. I just use npm rather than yarn. So that auto generated. Had to modify the git ignore otherwise it would have tried uploading that macOS hidden folder from my MBP. I would recommend the changelog.md even if it only starts with an entry for the latest update. The changelog md is more inline with the latest expectation of Homebridge plugins. Glad you were able to sort through the PR. *sorry if the formatting on this comment is a little weird, I’m writing on the GitHub mobile app.

sibartlett commented 4 years ago

Yeah, I will try to add the changelog... just I wanted to go to bed, and I been looking at this stuff for a while... 😄

I might also update the .gitignore file too... tip: you can add a global .gitignore

AppleTechy commented 4 years ago

Oh thanks for the tip regarding the global gitignore. Is there any reason I can't go ahead and delete my fork?

AppleTechy commented 4 years ago

Also I know you don't want to maintain. We created a homebridge-plugins repository to house no longer maintained plugins if you want to transfer ownership to that org. We can host it till someone else comes along and decides to maintain it. While adding you to still have access to the repo if you so decide you want to do something with it.