REMOVE_GAMMA and DITHER options were strings and always true in javascript

sibbl / hass-lovelace-kindle-screensaver

This tool generates a png from a Home Assistant Lovelace view, which can be displayed on a Kindle device which has the Online Screensaver plugin installed.

MIT License

311 stars 71 forks source link

REMOVE_GAMMA and DITHER options were strings and always true in javascript #118

Closed cosote closed 2 months ago

cosote commented 2 months ago

I realized that in COLOR_MODE TrueColor the colors were darker than in dashboard. Disabling the REMOVE_GAMMA switch didn't solve it. After debugging, I realized that the string "false" resulted in true condition in javascript, so I just patched the code to return a boolean.

sibbl commented 2 months ago

Great spot and thanks for directly fixing it via this PR!