Closed bictorv closed 2 years ago
Hi @bictorv,
sorry that I didn't take look earlier at your PR. Seems like I didn't immediately took action when I received the mail notification and then forgot about it - I'm really sorry!
Looks awesome!
Fixed the conflict.
@sibbl, any chance you'd have time to look at this? :-)
@bictorv thanks for fixing the conflict.
However, I also annotated some things some weeks ago. Mainly better naming and following some code style guidelines for modern JS. You should see them in the PR above, if I'm right?
I'd appreciate if these minor could things could be changed before I can merge the PR. Thanks :)
Sorry, I can't find any annotations? Could you point one out?
Please see if I pass the checks this time - I'm not a javascript programmer, really.
@bictorv thanks a lot 😊
@bictorv while setting it up for my home assistant, I've found some small things I've fixed.
When you move to the version I'm just releasing, please keep in mind to change the following things:
trigger.query
should become trigger.json
and the values are now batteryLevel
and isCharging
. They also are received as a number and boolean this way.batteryLevel
and isCharging
so we have the same naming through the whole application.Furthermore, I've fixed the https support and enabled the battery store to support multiple devices :) Thanks for your hard work and sorry again for the long time it took to merge this...! I really love the feature and am happy to use it in my setup as well.
Inspired by https://github.com/sibbl/hass-kindle-screensaver#optional-battery-level-entity