sibbl / hass-lovelace-kindle-screensaver

This tool generates a png from a Home Assistant Lovelace view, which can be displayed on a Kindle device which has the Online Screensaver plugin installed.
MIT License
335 stars 74 forks source link

Support for letting Home Assistant keep track of Kindle battery level #13

Closed bictorv closed 2 years ago

bictorv commented 3 years ago

Inspired by https://github.com/sibbl/hass-kindle-screensaver#optional-battery-level-entity

sibbl commented 2 years ago

Hi @bictorv,

sorry that I didn't take look earlier at your PR. Seems like I didn't immediately took action when I received the mail notification and then forgot about it - I'm really sorry!

blockarchitech commented 2 years ago

Looks awesome!

bictorv commented 2 years ago

Fixed the conflict.

bictorv commented 2 years ago

@sibbl, any chance you'd have time to look at this? :-)

sibbl commented 2 years ago

@bictorv thanks for fixing the conflict.

However, I also annotated some things some weeks ago. Mainly better naming and following some code style guidelines for modern JS. You should see them in the PR above, if I'm right?

I'd appreciate if these minor could things could be changed before I can merge the PR. Thanks :)

bictorv commented 2 years ago

Sorry, I can't find any annotations? Could you point one out?

bictorv commented 2 years ago

Please see if I pass the checks this time - I'm not a javascript programmer, really.

sibbl commented 2 years ago

@bictorv thanks a lot 😊

sibbl commented 2 years ago

@bictorv while setting it up for my home assistant, I've found some small things I've fixed.

When you move to the version I'm just releasing, please keep in mind to change the following things:

Furthermore, I've fixed the https support and enabled the battery store to support multiple devices :) Thanks for your hard work and sorry again for the long time it took to merge this...! I really love the feature and am happy to use it in my setup as well.