Make selector for element to wait for until rendering the page configurable

sibbl / hass-lovelace-kindle-screensaver

This tool generates a png from a Home Assistant Lovelace view, which can be displayed on a Kindle device which has the Online Screensaver plugin installed.

MIT License

311 stars 71 forks source link

Make selector for element to wait for until rendering the page configurable #57

Open emilic14 opened 1 year ago

emilic14 commented 1 year ago

Hello, First of all thanks! your project is giving my nook a second life ^^.

My bug is related to your await page.waitForSelector("home-assistant", { timeout: Math.max(config.renderingTimeout - navigateTimespan, 1000) }); Code, as I am personally not using lovelace but I am currently more of a Tileboard user... so this check is blocking. Easy fix but just thought I would share it.

sibbl commented 1 year ago

That's great to hear!

Probably we could make the selector configurable as well, defaulting to the current value home-assistant.

Will add it to my list (or appreciate a PR) 👍