search

sibbl / hass-lovelace-kindle-screensaver

This tool generates a png from a Home Assistant Lovelace view, which can be displayed on a Kindle device which has the Online Screensaver plugin installed.
MIT License
311 stars 71 forks source link

Cosmetic Add-On Bug: HA_BASE_URL in Asterisk/hidden #66

Closed The-May closed 4 months ago

The-May commented 1 year ago

I have added this Repo as Home Assistant Addon and it was recognized without any problem. It works without any problem but I stumbled upon a config value that is in asterisk (hidden) characters which in my opinion should not be: grafik Especially when the "hidden" value is shown in the logs as plain text.

Luckily the logs show if the path is right or not: grafik

This makes it harder to type in the string, but not impossible.

Thanks alot for merging and making it extremely easier for non tech savvi ppl.

sibbl commented 1 year ago

Hey, thanks for pointing this out and giving feedback about the newly added addon!

Indeed I guess the base URL might not have to be hidden. Maybe we could even find a solution to automatically get this (and the token) so it's an optional input you only need to fill if you really want to use a different Hass instance.

Not sure when I'll find time as it doesn't seem high prio for now, but it's definitely something we should improve.

PS: I love the "Cosmetic Add-On Bug" category 🤗

sibbl commented 4 months ago

It seems like this is a feature of the Home Assistant Add-Ons framework. We describe the parameter to be of type "url", which is supported according to their docs: https://developers.home-assistant.io/docs/add-ons/configuration/#options--schema

Why it's visualized this way is out of scope for this project.