sibiraj-s / ngx-editor

🖋️ Rich Text Editor for angular using ProseMirror
https://sibiraj-s.github.io/ngx-editor/
MIT License
424 stars 183 forks source link

[Feature request]: Missing functionalities from one of first version #394

Closed MDzyga closed 10 months ago

MDzyga commented 2 years ago

Proposal

Hi, I use one of first version ngx-editor and notice that you released new version. I noticed that you don't have all functionalities (listed below) which are in my version. Do you have them in your schedule?

image

I think the most important for me is horizontal line. image

In HTML it looks like stylish paragraph. <p style="border-top: 1px solid rgb(0, 0, 0); border-bottom: 1px solid rgb(0, 0, 0); border-left: none; border-right: none; padding: 0.01in 0in; direction: ltr; text-transform: uppercase; color: rgb(0, 0, 0); text-align: center;"></p>

Willing to submit a PR?

No response

sibiraj-s commented 2 years ago

Originally, the editor was built on top of execCommand where the implementation is straightforward but the api is unreliable. Later the editor is ported to use prosemirror, most of the features were made but some were not added which needs some time/effort to implement, which ATM I don't have.

I think the most important for me is horizontal line.

The rule is already there, but just not exported as menu. I can add that. should be a minor change.

sibiraj-s commented 10 months ago

Sorry for the long long delay.

The horizontal rule has been added, include menu item horizontal_rule to enable the item. it might be hidden by default.

Thank you

github-actions[bot] commented 9 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread.