sibiraj-s / ngx-editor

🖋️ Rich Text Editor for angular using ProseMirror
https://sibiraj-s.github.io/ngx-editor/
MIT License
424 stars 183 forks source link

[Bug]: Problem with @types/prosemirror-model after upgrading Angular from 13.3.0 to 13.3.5 #400

Closed VBobCat closed 2 years ago

VBobCat commented 2 years ago

What happened?

After upgrading Angular from 13.3.0 to 13.3.5, application is breaking at ng serve with two ocurrences of this error:

error TS2709: Cannot use namespace 'OrderedMap' as a type

Version

v12.4.0

Angular Version

v13.3.5

What browsers are you seeing the problem on?

No response

Link to reproduce

No response

Relevant log output

Error: node_modules/@types/prosemirror-model/index.d.ts:1147:40 - error TS2709: Cannot use namespace 'OrderedMap' as a type.

1147     nodes: { [name in N]: NodeSpec } | OrderedMap<NodeSpec>;
                                            ~~~~~~~~~~

Error: node_modules/@types/prosemirror-model/index.d.ts:1154:41 - error TS2709: Cannot use namespace 'OrderedMap' as a type.

1154     marks?: { [name in M]: MarkSpec } | OrderedMap<MarkSpec> | null | undefined;
                                             ~~~~~~~~~~

Willing to submit a PR?

No response

sibiraj-s commented 2 years ago

Can you try v12.4.1. I have pinned all the prosemirror definitely typed packages. Looks someone broke something on recent releases.

VBobCat commented 2 years ago

Hello, @sibiraj-s ! Thank you so much, it worked! But only after I ran ng new in a new folder, installed all my dependencies anew with npm (including ngx-editor) and and copied my src files to it. Your package is fantastic and I was worried with having to replace it.

sibiraj-s commented 2 years ago

Glad that worked 🎉

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread.