sibiraj-s / ngx-editor

🖋️ Rich Text Editor for angular using ProseMirror
https://sibiraj-s.github.io/ngx-editor/
MIT License
424 stars 183 forks source link

Custom color picker for text/background color selecting popup #415

Closed Mohammed-Rasik closed 1 year ago

Mohammed-Rasik commented 1 year ago

This PR contains:

Breaking Changes?

Checklist

Describe Your Changes

HTML custom color picker is added in text/background color selecting popup. If want to choose different color from presets, user can use this color picker. User can choose color by picking/by typing hex code. Also recently picked colors from color picker, which is also different from presets, displayed in the same popup as 'Recent Colors'.

Does this PR affects any existing issues?

sibiraj-s commented 1 year ago

Hi @Mohammed-Rasik Thanks for the PR. I forgot to get back on this.

Will look into this. Would have been better if a discussion/issue was created to discuss on this first. The reason the color picker is not added is that it looks/works different in different browsers.

And can you document the usage in the PR description too, api/options has to play along nicely with the current present.

sibiraj-s commented 1 year ago

Closing as not planning to implement this. Thank you.

github-actions[bot] commented 1 year ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread.