feat(icons): add support for custom icons in menu

sibiraj-s / ngx-editor

🖋️ Rich Text Editor for angular using ProseMirror

https://sibiraj-s.github.io/ngx-editor/

MIT License

458 stars 191 forks source link

feat(icons): add support for custom icons in menu #455

Closed jorgeucano closed 1 year ago

jorgeucano commented 1 year ago

This PR contains:

[ ] bugfix
[x] feature
[x] refactor
[x] tests
[x] documentation
[ ] others

Breaking Changes?

[ ] yes
[x] no

Checklist

[x] commit messages follow the Conventional Commits pattern
- A feature commit message is prefixed "feat:"
- A bugfix commit message is prefixed "fix:"
- A document related commit is prefixed "docs:"
[x] docs have been added / updated (for bug fixes / features)

Describe Your Changes

Add support for custom icons for add into the forRoot ie

      locals: {
        bold: 'This is bold',
      },
      icons: {
        bold: '<img src="https://cdn-icons-png.flaticon.com/512/1827/1827924.png " width="15" height="15" alt="" title="" class="img-small">',
      },
    })

Does this PR affects any existing issues?

[ ] yes
[x] no

jorgeucano commented 1 year ago

hey @sibiraj-s what do you think about the pr ??

sibiraj-s commented 1 year ago

Hi, @jorgeucano Thanks for creating the PR. Will check this tomorrow or the day after. I am stuck with some personal work.

Overall it looks good to me, let me check this later once again.

sibiraj-s commented 1 year ago

Also please update the docs somewhere as you see fit. And, I also have left some overall comments. hope it makes sense.

Thanks again @jorgeucano.

jorgeucano commented 1 year ago

thanks for review the pr I made the changes and response some questions! all is commited now!

sibiraj-s commented 1 year ago

Changes looks good. Please add few test cases for the code. Thank you.

let me know if any help is needed there.

jorgeucano commented 1 year ago

@sibiraj-s I added the test too!

sibiraj-s commented 1 year ago

@sibiraj-s I added the test too!

I will publish this today or by Sunday.

Thanks again @jorgeucano

github-actions[bot] commented 1 year ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread.