search

sibiraj-s / ngx-editor

🖋️ Rich Text Editor for angular using ProseMirror
https://sibiraj-s.github.io/ngx-editor/
MIT License
423 stars 182 forks source link

[Feature request]: Support Angular 16 #475

Closed IBlackI closed 10 months ago

IBlackI commented 11 months ago

Proposal

The current version of this package is for Angular version 14. Angular 16 has been released. Please create an updated version which has Angular 16 listed as a compatible version.

Willing to submit a PR?

No

TahaAttari commented 11 months ago

the docs say Angular 14+ is supported, so should the package.json just be updated to allow all v14+ instead of ^14.1 like it is now?

IBlackI commented 11 months ago

Currently the package.json specifies that version anything greater than or equals to 14.1.x but smaller than 15.x.x is supported. If version 15 and 16 are also supported the syntax would be ^14 || ^15 || ^16. If version 14.0.x is not supported but 14.1.x is it would become ^14.1 || ^15 || ^16. For more details this cheatsheet provides a quick overview.

The package.json does list the dependency on Angular correctly as a peer dependency.

sibiraj-s commented 10 months ago

Note. the package supports 14.1.0 or greater(including v16). The version between 14.0.0 and 14.1.0 is not supported due to a missing feature required by the editor to correctly implement dynamic components and was only added in v14.1

Support for v16 is explicitly added via 4a9e7d0b10aadcd2f438ba2cad630c5c9460675b. Will be published soon.

Closing this as the support is already there. Let me know if there are issues. ngx-editor v16 will also be released soon.

github-actions[bot] commented 9 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread.