search

sibiraj-s / ngx-editor

🖋️ Rich Text Editor for angular using ProseMirror
https://sibiraj-s.github.io/ngx-editor/
MIT License
458 stars 191 forks source link

[Bug]: Wrong `<input>` type for `url` #550

Closed Lapotor closed 5 months ago

Lapotor commented 6 months ago

What happened?

On popups where you have a URL field the <input> type is set to type="href" this is not a valid <input> type.

It should be type="url" to match valid valid <input> type.

https://github.com/sibiraj-s/ngx-editor/blob/3741a9ebd10e4ab004d22ac02c6206fb8f68a85a/projects/ngx-editor/src/lib/modules/menu/link/link.component.html#L23

https://github.com/sibiraj-s/ngx-editor/blob/3741a9ebd10e4ab004d22ac02c6206fb8f68a85a/projects/ngx-editor/src/lib/modules/menu/image/image.component.html#L23

Version

v17.5.4

Angular Version

v17.3.9

What browsers are you seeing the problem on?

Firefox

Link to reproduce

No response

Relevant log output

No response

Willing to submit a PR?

Yes

Lapotor commented 6 months ago

There for this rule don't apply to the URL fields:

https://github.com/sibiraj-s/ngx-editor/blob/3741a9ebd10e4ab004d22ac02c6206fb8f68a85a/projects/ngx-editor/src/lib/editor.component.scss#L326-L329

sibiraj-s commented 6 months ago

Thanks for catching this, Please raise a PR. will get that deployed soon.

github-actions[bot] commented 4 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread.