search

sibiraj-s / ngx-editor

🖋️ Rich Text Editor for angular using ProseMirror
https://sibiraj-s.github.io/ngx-editor/
MIT License
457 stars 191 forks source link

[Bug]: "insert command" button like "Clear formatting" triggers a form submit #564

Closed natharduini closed 1 week ago

natharduini commented 4 months ago

What happened?

My ngx-editor is in a form and when I click the "Clear formatting" menu button, it triggers a form submission.

Adding type="button" in insert-command.component.html prevents that.

Version

v17.x.x

Angular Version

v17.x.x

What browsers are you seeing the problem on?

Firefox, Chrome

Link to reproduce

https://stackblitz.com/edit/ngx-editor-vanv24

Relevant log output

No response

Willing to submit a PR?

Yes

matthiassommer commented 1 week ago

I noticed the same for horizontal_rule and format_clear