sibiraj-s / ngx-editor

🖋️ Rich Text Editor for angular using ProseMirror
https://sibiraj-s.github.io/ngx-editor/
MIT License
457 stars 191 forks source link

[Bug]: tabindex change in v17.1 requires excessive tabbing through menu #586

Open paulirwin opened 1 day ago

paulirwin commented 1 day ago

What happened?

The change in #531, while well-intentioned, created a regression that my users have found frustrating. Now, if you tab onto the menu bar (i.e. from an earlier field in the form), you now have to tab through all of the menu items to get to the text area. In my case, I have 13 menu bar items, so as you can imagine it is frustrating for users to have to tab through 13 items to get to the text area, and usually resort to using the mouse instead.

Note that other apps do not require you to do this to achieve keyboard accessibility. Teams and GitHub, to cite just two examples, let you tab onto the menu bar (achieving what #531 wanted to accomplish) but then you use the arrow keys (and not tab) to navigate to the other menu options if needed. Pressing tab just once while focused on any menu bar item moves the focus to the text area as users expect.

This can be reproduced on the demo site: https://ngx-editor.stackblitz.io/ - either after page load press tab more than once, or put your cursor in the text field and press shift+tab to tab backwards onto the menu bar.

Version

v18.0.0

Angular Version

v18.2

What browsers are you seeing the problem on?

No response

Link to reproduce

https://ngx-editor.stackblitz.io/

Relevant log output

No response

Willing to submit a PR?

Yes

sibiraj-s commented 1 day ago

Hi,

I do understand the frustration. Would you be willing to fix it via a PR? I am open to the fix, I can work similar to the github editor.

Since I am currently super occupied, I am unable to fix this immediately