search

sibiraj-s / ngx-editor

🖋️ Rich Text Editor for angular using ProseMirror
https://sibiraj-s.github.io/ngx-editor/
MIT License
424 stars 183 forks source link

Feat toolbar font #73

Closed donhmorris closed 6 years ago

donhmorris commented 6 years ago

Feature toolbar font size

I'm submitting a...

Checklist

Added new default for toolbar font size to the default config object. Name of default is toolbarFontSize.

Use Nothing is required to utilize the default font size for the toolbar. If a different font size is desired, pass in a config object to ngx-editor with the toolbarFontSize field set to a legal CSS value for font-size.

Does this PR introduce a breaking change?

Does this PR affects any existing issues?

sibiraj-s commented 6 years ago

@donhmorris. This can be done with pure css. why Config.

Any particular reason or motivation?

donhmorris commented 6 years ago

Hi Sibiraj. Well, I tried that but I couldn’t get it to work. Maybe a small example in docs would help.

While I have you, how would you feel about updating the icons to font awesome 5?

Regards, Don Morris

From: Sibiraj notifications@github.com Reply-To: Sibiraj-S/ngx-editor reply@reply.github.com Date: Tuesday, February 27, 2018 at 11:40 PM To: Sibiraj-S/ngx-editor ngx-editor@noreply.github.com Cc: Don Morris donhmorris@hotmail.com, Mention mention@noreply.github.com Subject: Re: [Sibiraj-S/ngx-editor] Feat toolbar font (#73)

@donhmorrishttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdonhmorris&data=02%7C01%7C%7Cb211363699df44af3ef708d57e657147%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636553896504363854&sdata=p13XVYIi1ZcedBDbB1ecyEpjmeXSnj6B5OJxwBbbIIM%3D&reserved=0. This can be done with pure css. why Config.

Any particular reason or motivation?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSibiraj-S%2Fngx-editor%2Fpull%2F73%23issuecomment-369119635&data=02%7C01%7C%7Cb211363699df44af3ef708d57e657147%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636553896504363854&sdata=kt30L9fp7kvT%2BnSurrezGRfpdPMllSHlI%2FxLkJn8kk4%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALadgBuvBU9bnpI-NihgZMGOjOXUUDULks5tZNjQgaJpZM4SWB0s&data=02%7C01%7C%7Cb211363699df44af3ef708d57e657147%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636553896504363854&sdata=oj4Pbljs%2F1uiB3KSyrdv8IoW01kGX%2F2Tby3jr4AJmdc%3D&reserved=0.

sibiraj-s commented 6 years ago

What did you do,

This should work, if you do this in global css

.ngx-toolbar {
    font-size: 1rem !important;
}

In case of css at component level

::ng-deep .ngx-toolbar {
    font-size: 1rem !important;
}
sibiraj-s commented 6 years ago

While I have you, how would you feel about updating the icons to font awesome 5?

Already on my list. I was going through font-awesome 5. It make take a week or two. Little busy 😅 . @donhmorris

donhmorris commented 6 years ago

Sure, I’ll do it if you want.

It might be possible to support both. I’ll give it a try.

Regards, Don Morris

On Feb 27, 2018, at 11:57 PM, Sibiraj notifications@github.com<mailto:notifications@github.com> wrote:

While I have you, how would you feel about updating the icons to font awesome 5?

Already on my list. I was going through font-awesome 5. It make take a week or two. Little busy 😅 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSibiraj-S%2Fngx-editor%2Fpull%2F73%23issuecomment-369121752&data=02%7C01%7C%7Cfe83d42639b54686e9f708d57e67b58d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636553906244601753&sdata=nN22xFtg%2FHR%2BAs6TWBQxwBcFqNaCtbjWTbFd6%2F%2FJrrk%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALadgHQmhZ8Kc1Jh7umZ2LMHBayitaM9ks5tZNycgaJpZM4SWB0s&data=02%7C01%7C%7Cfe83d42639b54686e9f708d57e67b58d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636553906244601753&sdata=EjZIJH4iW4pW%2Fx6RSPoFaY8c%2F9V%2BC%2FYUFQuQp7UTvV8%3D&reserved=0.

sibiraj-s commented 6 years ago

Close this PR, if you can work with CSS solution, coz I don't want to clutter up with too much option that has a simple solution

Also follow this official package https://github.com/FortAwesome/angular-fontawesome.

Soon I will migrate to font awesome 5 this week or the latter

donhmorris commented 6 years ago

Ok

Regards, Don Morris

On Feb 28, 2018, at 12:09 AM, Sibiraj notifications@github.com<mailto:notifications@github.com> wrote:

Close this PR, if you can work with CSS solution, coz I don't want to clutter up with too much option that has a simple solution

Also follow this official package https://github.com/FortAwesome/angular-fontawesomehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FFortAwesome%2Fangular-fontawesome&data=02%7C01%7C%7C7ba9a79971484d7ba34c08d57e696ee5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636553913647138426&sdata=VF6oRe330fzdDegmDf12L6In3flPZMGRfvoJYtLeWmQ%3D&reserved=0.

Soon I will migrate to font awesome 5 this week or the latter

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSibiraj-S%2Fngx-editor%2Fpull%2F73%23issuecomment-369123430&data=02%7C01%7C%7C7ba9a79971484d7ba34c08d57e696ee5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636553913647138426&sdata=PaKWksGbxzj4oEVsn319BHXZsKmPE5KX0vDMz%2BEw8MM%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALadgAZxSvFWIwxVEN3wIvisYun23CUwks5tZN-BgaJpZM4SWB0s&data=02%7C01%7C%7C7ba9a79971484d7ba34c08d57e696ee5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636553913647138426&sdata=M7XFBV0S0nyU6XkVnrNYUY9o5N4j32u7caIPpJ8JGhY%3D&reserved=0.

donhmorris commented 6 years ago

Sibiraj, I’m going to pass on this. I don’t really see the benefit of the fortawesome library. From what I can see it just provides a directive for things the plain font awesome library can already do. It looks like simple code bloat to me. I wouldn’t feel good about spending time on using fortawesome.

Here is a link to the usage page for version 5 in case you haven’t seen it: https://fontawesome.com/how-to-use/svg-with-js

Sorry to bale on you for this item. If there is anything else I can help with, let me know.

Regards, Don Morris

From: Sibiraj notifications@github.com Reply-To: Sibiraj-S/ngx-editor reply@reply.github.com Date: Wednesday, February 28, 2018 at 12:09 AM To: Sibiraj-S/ngx-editor ngx-editor@noreply.github.com Cc: Don Morris donhmorris@hotmail.com, Mention mention@noreply.github.com Subject: Re: [Sibiraj-S/ngx-editor] Feat toolbar font (#73)

Close this PR, if you can work with CSS solution, coz I don't want to clutter up with too much option that has a simple solution

Also follow this official package https://github.com/FortAwesome/angular-fontawesomehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FFortAwesome%2Fangular-fontawesome&data=02%7C01%7C%7C7ba9a79971484d7ba34c08d57e696ee5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636553913647138426&sdata=VF6oRe330fzdDegmDf12L6In3flPZMGRfvoJYtLeWmQ%3D&reserved=0.

Soon I will migrate to font awesome 5 this week or the latter

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSibiraj-S%2Fngx-editor%2Fpull%2F73%23issuecomment-369123430&data=02%7C01%7C%7C7ba9a79971484d7ba34c08d57e696ee5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636553913647138426&sdata=PaKWksGbxzj4oEVsn319BHXZsKmPE5KX0vDMz%2BEw8MM%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALadgAZxSvFWIwxVEN3wIvisYun23CUwks5tZN-BgaJpZM4SWB0s&data=02%7C01%7C%7C7ba9a79971484d7ba34c08d57e696ee5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636553913647138426&sdata=M7XFBV0S0nyU6XkVnrNYUY9o5N4j32u7caIPpJ8JGhY%3D&reserved=0.

sibiraj-s commented 6 years ago

@donhmorris . Thanks for your valuable time. Sure I will look into it.

Also, i made some study on fontawesome 5. But the new features doesn't play well with angular. And it is mentioned by a person on that team. And he recommended to use the web fonts.

If web fonts are the solution there is no big difference between 4 and 5 except few new icons.

Follow #58 . I will work on this problem there.

Sorry to bale on you for this item. If there is anything else I can help with, let me know.

Sure I could use all help i can get :smile:

donhmorris commented 6 years ago

Some of the names are different. For example repeat is missing.

I’ve used version 5 on 3 angular projects using just the link. No problems. I’m using some of the spinners too. I’ll checkout the link you sent me.

Regards, Don Morris

On Feb 28, 2018, at 2:26 PM, Sibiraj notifications@github.com<mailto:notifications@github.com> wrote:

@donhmorrishttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdonhmorris&data=02%7C01%7C%7Cab6b72079da24a8b1a6408d57ee129bb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636554427877493698&sdata=5AiNd5GZHgzLrNcGr1uyVNfIwWNp3mBJNCB0aCN5Uts%3D&reserved=0 . Thanks for your valuable time. Sure I will look into it.

Also, i made some study on fontawesome 5. But the new features doesn't play well with angular. And it is mentioned by a person on that team. And he recommended to use the web fonts.

If web fonts are the solution there is no big difference between 4 and 5 except few new icons.

Follow #58https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSibiraj-S%2Fngx-editor%2Fissues%2F58&data=02%7C01%7C%7Cab6b72079da24a8b1a6408d57ee129bb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636554427877493698&sdata=10KuPW1zydHtUnd7Q%2FOZj3xcaVVP1q8wUVdpSgKvytA%3D&reserved=0 . I will work on this problem there.

Sorry to bale on you for this item. If there is anything else I can help with, let me know.

Sure I could use all help i can get 😄

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSibiraj-S%2Fngx-editor%2Fpull%2F73%23issuecomment-369353835&data=02%7C01%7C%7Cab6b72079da24a8b1a6408d57ee129bb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636554427877493698&sdata=E9Vs8lljM%2FL1%2FfCo%2FC4M7jpzECNKrXG1YNGJdfLPuqk%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALadgN1YAWNbO55giMDQnrUn_qxrIvZpks5tZahhgaJpZM4SWB0s&data=02%7C01%7C%7Cab6b72079da24a8b1a6408d57ee129bb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636554427877493698&sdata=5cF1tDepymwyKt2e5krOmUytJSVxIkt8iUfAQ7iqHcU%3D&reserved=0.

github-actions[bot] commented 2 years ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread.