This is just a suggestion to migrate to standalone components etc

sibiraj-s / ngx-tiptap

Angular bindings for tiptap v2

https://sibiraj-s.github.io/ngx-tiptap/

MIT License

126 stars 19 forks source link

This is just a suggestion to migrate to standalone components etc #70

Open Julian-B90 opened 4 months ago

Julian-B90 commented 4 months ago

Migrate Lib to Standalone API
Update Cypress 13.13.0

sibiraj-s commented 3 months ago

Thanks, Will look into it. I would have preferred a discussion prior to making breaking changes.

Julian-B90 commented 3 months ago

Maybe with that https://github.com/sibiraj-s/ngx-tiptap/pull/70/commits/2eb86c0a303c2fd42630eaff466fbe37bba937e3 we can offer both?

sibiraj-s commented 3 months ago

Maybe with that 2eb86c0 we can offer both?

I am not sure at this point if there would be any size increase if both are provided, since I never tried it.

Also, its fine to make breaking changes for a better API or make it more easy to use. I just said I wish there could have been a discussion nothing else.

sibiraj-s commented 1 month ago

Sorry for the delay, If you could resolve the conflicts, I can get it merged and released as next major.

Julian-B90 commented 1 month ago

@sibiraj-s i have resolve the merge conflicts

Julian-B90 commented 3 weeks ago

@sibiraj-s ?