search

sibiraj-s / svelte-tiptap

Svelte components for tiptap v2
https://sibiraj-s.github.io/svelte-tiptap/
MIT License
244 stars 21 forks source link

Packaging Upgrades #16

Closed DougAnderson444 closed 1 year ago

DougAnderson444 commented 1 year ago

Hey this is a really cool TipTap extension, I'm a big fan of Svelte and noticed most of their TipTap stuff is React & Vue.

I have noticed that the current build of this repo doesn't add .js extensions when the TS is transformed, which is messing up some of my use of this package.

Do you mind if I submit a Pull Request to updated the packaging pipeline to fix this? I've already made the changes in my fork.

DougAnderson444 commented 1 year ago

@sibiraj-s The original package error I was seeing:

image

It is because unpkg doesn't like Typescript file, specifically their lack of extensions. But the new packaging method adds the extensions when transforming them to javascript.

sibiraj-s commented 1 year ago

A lot has been updated with v1.0.0, may be it shouldn't throw any errors.

Thank you

github-actions[bot] commented 5 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread.