Correctly handle scans_to_review.csv

sibis-platform / ncanda-data-integration

This is the Data Integration, MRI, and Bioinformatics Component of the National Consortium on Alcohol and NeuroDevelopment in Adolescence (NCANDA), funded by the NIAAA.

https://www.nitrc.org/projects/ncanda-datacore

BSD 3-Clause "New" or "Revised" License

4 stars 10 forks source link

Correctly handle scans_to_review.csv #397

Closed shippy closed 3 years ago

shippy commented 3 years ago

Fixes #396.

shippy commented 3 years ago

To test:

[x] it doesn't interfere with unreviewed scans
[x] it correctly doesn't overwrite existing judgment
[x] it moves the file to reviewed/ whenever a new judgment is entered
[ ] when partially reviewed, unreviewed scans are written back out
[x] it doesn't choke when scans_to_review.csv is absent (e.g. because it's been moved)

shippy commented 3 years ago

The lockfile isn't added cleanly (that would require a context manager), but it is added.