search

sibojia / google-glog

Automatically exported from code.google.com/p/google-glog
Other
0 stars 0 forks source link

[PATCH] do not rely on errno values #123

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently, the glog test suite (not the glog library itself) relies on precise 
values of few errno constants (ENOENT=2, EINTR=4, ENXIO=6, ENOEXEC=8).
This is not POSIX compliant[1], as actual errno values are 
implementation-defined (and some even vary their values among different 
architectures for the same OS).

The attached patch adds a replacement system for errno values in addition to 
the one used to replace descriptions of errno values.

[1] 
http://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_
03

Original issue reported on code.google.com by toscano....@tiscali.it on 20 Apr 2012 at 4:54

Attachments:

GoogleCodeExporter commented 9 years ago 
Sorry for the latency, thanks for the patch! This patch and the patch in Issue 
124 look good to me.

Could you sign our Individual Contributor License Agreement, please? It
seems that we need to ask you to sign this to avoid any troubles. The
process is just submitting an HTML form, and it shouldn't take your
time so much.

http://code.google.com/legal/individual-cla-v1.0.html

Please note that these forms do not transfer copyright: the
contributor retains her ownership in the work. The CLA just grants
Google a "perpetual, non-exclusive, royalty-free, etc..." right to use
the work, sublicense it, and so on.

Original comment by shinichi...@gmail.com on 9 May 2012 at 8:18