search

sibradzic / amdgpu-clocks

Simple script to control power states of amdgpu driven GPUs
GNU General Public License v2.0
390 stars 43 forks source link

Make shellcheck happy #52

Closed murlakatamenka closed 4 months ago

murlakatamenka commented 1 year ago

This PR is a minor refactor that makes shellcheck happy about the scripts. Better be safe than sorry when using bash to work with configuring hardware, right?

I've grouped changes into individual commits so that it's easier to see what's been changed and/or cherry-pick them. There are also links to shellcheck wiki in commit bodies.

Tested the branch on my own hardware.

murlakatamenka commented 4 months ago

@sibradzic should I even bother rebasing it?

sibradzic commented 4 months ago

@sibradzic should I even bother rebasing it?

by all means :bow:

sibradzic commented 4 months ago

@murlakatamenka rebased & merged in #58 Much obliged!