search

sibradzic / amdgpu-clocks

Simple script to control power states of amdgpu driven GPUs
GNU General Public License v2.0
393 stars 44 forks source link

Enable service immediately #8

Closed j-m-hoffmann closed 4 years ago

j-m-hoffmann commented 4 years ago

spares a reboot

sibradzic commented 4 years ago

hi @j-m-hoffmann thanks for the PR. I would merge this immediately, but there is one thing regarding $ vs # in the README.md. Well, # was supposed to indicate the commands are executed as root, as # is a common root prefix in common terminals. Do you think $ is supposed to be "more uniform"? If so, please add text comments describing which commands are supposed to be run as root, or add sudo prefix where necessary...

j-m-hoffmann commented 4 years ago

i think making it explicit using sudo is the best way