search

sibradzic / upp

A tool for parsing, dumping and modifying data in Radeon PowerPlay tables
GNU General Public License v3.0
154 stars 24 forks source link

set --write is not taken into account #2

Closed cdarken closed 5 years ago

cdarken commented 5 years ago

Hi. I'm trying to use your tool to modify some settings in the PP tables for a Polaris card. But when I try to set them I get this error:

WARNING: Nothing was written to '/sys/class/drm/card1/device/pp_table'. Add --write option to commit the changes for real!

My command line:

sudo ./upp.py -i /sys/class/drm/card1/device/pp_table set --write /MemClockDependencyTable/Entries/2/Vddci=800
cdarken commented 5 years ago

I think I found the issue. Here you use 'False' to set the default value and I modified it to False as I think it needs to be a boolean.

sibradzic commented 5 years ago

Thanks for report @cdarken, yeah, that click option default was wrongly initialized, fixed it in 7272b0b