search

sibson / vncdotool

A command line VNC client and python library
Other
451 stars 120 forks source link

feat(rfb): Support RFB 4.[01] and 5.0 #248

Closed pmhahn closed 1 year ago

pmhahn commented 1 year ago

New server versions still work with clients only supporting 3.008, as long as they announce it that way.

Limit client version to 3.008

Closes #245

This is untested, someone™ with Intel AMT KVM, RealVNC 4.6 or RealVNC 5.3 should test this.

pmhahn commented 1 year ago

I have setup one of my RaspberryPis with RealVNC, which reports itself as RFB 005.000, which is now considered valid. But the connection still fails as it requires newer AuthTypes:

INFO:twisted:Using protocol version 3.8
INFO:twisted:Offered <AuthTypes.RSA_AES_2STEP: 13>
INFO:twisted:Offered <AuthTypes.RSA_AES: 5>
INFO:twisted:Offered <AuthTypes.RSA_AES_UNENCRYPTED: 6>
INFO:twisted:Offered <AuthTypes.RSA_AES256_UNENCRYPTED: 130>
INFO:twisted:Offered <AuthTypes.REALVNC_192: 192>
INFO:twisted:unknown security types: (13, 5, 6, 130, 192)

So: yes it adds support for newer RFB server versions, but no, that is not enough. Someone™ should implement more Security Types