search

sibvisions / flutter_jvx

A generic Flutter app for JVx applications.
Apache License 2.0
3 stars 1 forks source link

Update default Log Levels and add as config option #134

Closed rjahn closed 1 year ago

rjahn commented 1 year ago

Default log setting logs many things? Not sure if this slows down the application a little bit?

image

Is there a loglevel or something to configure?

ToniHeiss commented 1 year ago

You can configure the log level only via the code. In the class "FlutterUI" are statically defined logged with their respective log level. There you can change them. We should make them somewhat accessible in the near future.

rjahn commented 1 year ago

OK, but the config should be different in dev and prod mode!

ToniHeiss commented 1 year ago

Only the default logger is set to two different levels depending on the mode(prod: info, debug: debug). The rest always logs on info. In prod we should probably go down to warnings.

rjahn commented 1 year ago

or error?

ToniHeiss commented 1 year ago

We could. But if we integrate some kind of files log or remote log for future users, we should stay on warning level so we can potentially see errors coming and how they formed, instead of just reacting to the errors themselves.

rjahn commented 1 year ago

WARN is better than INFO right now

Bungeefan commented 1 year ago

We should add the option to customize log levels via config.