search

sibvisions / javafx.DndTabPane

Drag'n'Drop TabPane extension for standard JavaFX
Eclipse Public License 1.0
10 stars 0 forks source link

Neither tab marker is able to handle a TabPane oriented horizontally. #2

Open jdngray77 opened 2 years ago

jdngray77 commented 2 years ago

Everything functionally operates as expected when a tab pane has the tabs placed on the side, rather than than the top.

The markers, however, aren't positioned correctly.

https://user-images.githubusercontent.com/50697488/184257426-44b135fe-17d8-46c7-9f34-3bb421950b1f.mov

https://user-images.githubusercontent.com/50697488/184257851-8fcb0e49-b48e-4c9f-9ecf-66b344922c6b.mov

rjahn commented 2 years ago

see https://github.com/sibvisions/javafx.DndTabPane

The tabset is part of: org.eclipse.fx.ui.controls

We don't fix in this repository.

jdngray77 commented 2 years ago

Are you sure?

The issues seem to be with the markers, not the tabs, which are in this repository.

For example, this part here where it calculates the line seen in the first video - it may just need a few tweaks to handle different tab positions.

Is there something i'm missing?

RobertZenz commented 2 years ago

Are you sure?

The issues seem to be with the markers, not the tabs, which are in this repository.

No, what @rjahn meant is that we've copied the control/code from the SWTonFX project. We've only copied the source code verbatim with minor tweaks (if I remember correctly) with no intentions of diverging from the upstream project. We only needed that one control and did not want to have a dependency on the SWTonFX library as a whole. Whether upstream has diverged in the meantime (got rid of the markers or something) I can not tell, haven't looked at this in quite some time and the overall interest in JavaFX seems to have died down since then, too.

For example, this part here where it calculates the line seen in the first video - it may just need a few tweaks to handle different tab positions.

Yes and no. From what I could see it's split between the markers themselves, and the the factory method. Might not be as easy to implement that change and revamping the marker support completely might be easier...but out of scope for this repository. Ideally that would happen upstream...but upstream seems dead, so there's that...

I also don't have a setup to run this right now so that I could test it or implement it myself.

jdngray77 commented 2 years ago

Gotcha, up to speed.

In which case - If there's little intention on a fix - i'll likely just modify the line marker as a solution for my project alone.

Appreciate the consideration regardless!

RobertZenz commented 2 years ago

I can't speak for this project anymore, but given that upstream is stale I guess if you come up with a solution, a MR would still be nice to have here. You might also want to check whether or not upstream still accepts patches like this, or if the project lead is completely gone.

If I remember correctly, JVx does have support to have tabs aligned vertically, so such a patch would still benefit JVx. Though, I have no idea what the current state of the JavaFX implementation currently is, and whether it is actually used by someone or not. So, no promises there.