sibvisions / reactUI

A generic react UI for JVx applications.
Apache License 2.0
3 stars 2 forks source link

Error popup styling #494

Closed rjahn closed 1 month ago

rjahn commented 5 months ago

Open Contacts Error (DB) and try to change the selected record:

Safari:

image

Chrome:

image

Safari shows a small line above buttons (until you move the window) and Chrome doesn't show the line. Both browsers show round gray corners:

image

So there's something wrong!

The desktop UI:

image

There's no gray line.

If you test with Messages screen and open the Information:

image

looks in react UI:

image

So there's something wrong with styling, because:

Error popup has shadow in header, messages doesn't have such shadow. Error popup has big paddings, message doesn't use the same padding.

With Messages screen, you can test both, with Button:

rjahn commented 5 months ago

the error dialog paddings are not good enough, because the right padding is not the same as the left? buttons vs. icon...

gimmixAT commented 4 months ago

There also seems to be a difference between an actual error (e.g. in Contacts Error) and the Error styled Dialog in the Messages screen.

I'd suggest the following adjustments:

rjahn commented 4 months ago

We have different message popups:

But the only difference should be the Stack Trace... the styling should be the same.

So, please do your recommended changes.

gimmixAT commented 3 months ago

the styling of the two different error dialogs should be harmonized now