sicara / sicarator

Instant Setup & Best Quality for Data Projects!
Apache License 2.0
176 stars 9 forks source link

Black, Isort and Pylint not working when starting from scratch #31

Open emilio-desousa opened 1 year ago

emilio-desousa commented 1 year ago

Problem

I have created a project from scratch and when I run the pre-commit hook, I got an error tells that black command not found

image

Idea

Replace Black Isort and Lint by make commands

ywolff commented 1 year ago

Have you setup your venv using pyenv-virtualenv as explained in the generated project README.md? It should enable your venv each time you cd in your project folder, so that black and other Python commands should be found.

By the way, the reason why they are not written as make commands is to be able to run black (or other tools) only on the modified files (thanks to pass_filenames=true, which is the default value).

I'm labeling the issue as "documentation", because maybe this behavior should be better documented.