search

sicara / tf-explain

Interpretability Methods for tf.keras models with Tensorflow 2.x
https://tf-explain.readthedocs.io
MIT License
1.02k stars 112 forks source link

Accept opencv alternatives #144

Closed boussoffara closed 4 years ago

boussoffara commented 4 years ago

A possible fix to #142 : remove tensorflow and opencv dependency from setuptools but check for a valid version at import time and raise a helpful error: "TF-explain requires Opencv. Install Opencv via pip install opencv-python" "TF-explain requires TensorFlow 2.0 or higher. Install TensorFlow via pip install tensorflow"

Assuming most users would have a flavor of both installed this would avoid installing conflicting packages. For beginners the error should quickly guide them to the fix

RaphaelMeudec commented 4 years ago

@boussoffara LGTM! Thanks for the contribution!