search

sicara / tf-explain

Interpretability Methods for tf.keras models with Tensorflow 2.x
https://tf-explain.readthedocs.io
MIT License
1.02k stars 112 forks source link

Requesting support for TF2.3.x #156

Closed dspyrhsu closed 3 years ago

dspyrhsu commented 3 years ago

When trying to run GradCAM with TF 2.3.0, I run into this issue. The very same notebook using TF 2.2 works, but I have found TF2.2 to be more or less a desaster, especially concerning performance (e.g., loading the saved model takes minutes as opposed to a few seconds with TF2.3). So, if you plan on supporting TF 2.3, that would be highly appreciated.

And: thanks for sharing your work!

palatos commented 3 years ago

Just out of curiosity, if you use this fork, does it solve the current error? https://github.com/palatos/tf-explain

dspyrhsu commented 3 years ago

So, after doing this:

python -m pip install --upgrade git+https://github.com/palatos/tf-explain
[... snip ...]
Successfully installed tf-explain-0.2.1

The rror is gone! Thus, please write the pull request and thanks for your effort, @palatos !

palatos commented 3 years ago

@dspyrhsu I'm glad it worked! I was having the same issue and tried out a suggestion I saw someone else post, on that fork. I think there is a similar pull request currently under review, but I'm glad this workaround is working for you too.

RaphaelMeudec commented 3 years ago

@dspyrhsu @palatos the problem is fixed on master, thanks for raising it! It will be shipped in a release next week after we merge #161