sickcodes / Docker-OSX

Run macOS VM in a Docker! Run near native OSX-KVM in Docker! X11 Forwarding! CI/CD for OS X Security Research! Docker mac Containers.
https://hub.docker.com/r/sickcodes/docker-osx
GNU General Public License v3.0
45.33k stars 2.4k forks source link

VNC Naked version does not respect GENERATE_SPECIFIC #602

Open mike-lloyd03 opened 1 year ago

mike-lloyd03 commented 1 year ago

When building an image with https://github.com/sickcodes/Docker-OSX/blob/master/vnc-version/Dockerfile.nakedvnc, I am unable to get it to generate specific serials/UUIDs passed in via the environment.

version: "3"

services:
  main:
    restart: unless-stopped
    devices:
      - /dev/kvm
    volumes:
      - /opt/docker/macvm/mac_hdd_ng_auto.img:/image
    image: docker-osx:nakedvnc
    ports:
      - 50922:10022
      - 5998:5999
    environment:
      - GENERATE_SPECIFIC=true
      - WIDTH=1600
      - HEIGHT=900
      - RAM=6

In my .env I have:

DEVICE_MODEL="MacBookPro9,1"
SERIAL=*********
BOARD_SERIAL=*****************
UUID=********-****-****-****-************
MAC_ADDRESS=**:**:**:**:**:**

But when I boot the machine, it is using the default serials and UUIDs. I think the problem is because the Dockerfile has two CMD instructions and only the second one is being executed (per Docker docs).

How can this Dockerfile be reworked to allow GENERATE_SPECIFIC to be honored?

sickcodes commented 1 year ago

Yeah someone else created that file. I'll bring it in line with the others

chirmstream commented 1 year ago

Mike, where you able to get your serials to be passed through? I believe I am having the same issue as you. I'll take a stab at fixing the nakedvnc Dockerfile if its still broken.

chirmstream commented 12 months ago

I had no luck with changing the nakedvnc docker file. I built my own copy of docker-osx:latest with my personal serials hard coded in, then built the nakedvnc container with the base image set to my own.