Enhanced types on register method fix.

sicpa-dlab / acapy-resolver-didcomm

Aries cloud agent python plugin for resolving DIDs through the Universal DID Resolver using DIDComm messages.

Apache License 2.0

1 stars 2 forks source link

Closed burdettadam closed 3 years ago

burdettadam commented 3 years ago

Methods are now Sets, imports have been sorted and a few more type hints to make pyright happier.

Signed-off-by: Adam Burdett burdettadam@gmail.com

Luis-GA commented 3 years ago

I think it is a good decision to manage the methods as a set to their operations.

Luis-GA commented 3 years ago

LGTM! The only remaining thing is to pass the integration test pass. It seems that the current logic doesn't have the e2e behaviour expected.

dbluhm commented 3 years ago

Integration tests should be addressed by #21