search

sicpa-dlab / acapy-resolver-universal

(Archived) ACA-Py Plugin for HTTP Universal Resolver bindings
3 stars 2 forks source link

feat: dynamically configure supported methods #16

Closed dbluhm closed 2 years ago

dbluhm commented 2 years ago

Signed-off-by: Daniel Bluhm dbluhm@pm.me

swcurran commented 2 years ago

@dbluhm -- this change -- in particular, the locking of ACA-Py to 0.7.3 has broken the AATH ACA-Py build, so we can't run any tests on AATH.

Who do we break this. Presumably you are locking to ACA-Py 0.7.3 for some reason, but in order to use AATH, we need this to float to match whatever version of ACA-Py we are using in AATH.

For now, I can change the AATH requirements to use the commit before this one, but let me know what is going on with this and what ideas you have on how we can keep using this in AATH.

FYI -- @andrewwhitehead @nodlesh

Thanks!

dbluhm commented 2 years ago

Apologies for the headache! I merged into main not realizing AATH was pointing at the head of main.

We're in the middle of preparing to eventually open a PR to ACA-Py to include this directly within ACA-Py. We'll continue this work on the next branch. I've reverted main to its previous state. I've also tagged main at its current state as v0.1.0 and would recommend pinning to that or a specific commit hash.

Pinning to 0.7.3 was likely unnecessary for those changes, anyways :grimacing:

swcurran commented 2 years ago

It was more an issue with pip giving us misleading information -- once we did enough to see the real issue it was easy. I'll update the tag.

When I saw the issue I wondered why this wasn't in the Hyperledger world, so good to hear you are putting that into ACA-Py. We'll have to remember remove this as an AATH acapy-main requirement when that is done.

Thanks for resolving!