Closed vongohren closed 1 year ago
Hi all, me and @yvgny are planning to fix this issue. Please be patient, we will do it.
Great stuff! This is quite bad to use acctually becaues I have to write a "converter" if im going to follow your types.
And I assume your types are important as the data structure further down has to follow this structure.
So its great if the different types are updated to the standard, as did service attribute also seems out of date.
Hi @vongohren, the main
branch is now updated with types aligned to the standards. Let me know if you still find any discrepancies. Once it's stabilized we can issue a new release of the lib too.
What
This should be
id
- https://www.w3.org/TR/did-core/#did-document-propertiesthis should be
keyAgreements
- https://www.w3.org/TR/did-core/#did-document-propertiesSo I dont know how literal to the spec one should be, but the resolved documents will not be of proper attributes if these types are correct.
Why
Because the produced type is not correct to what a did doc should be if you want to work with other libraries.
Success Criteria
Anything else