service_endpoint is not abbreviated properly as it looking for serviceEndpoint instead, so serivce_endpoint gets added to extra and when it is decoded, this constructor gets passes multiple parameters with the name 1service_endpoint`.
This change would abbreviate python and javascript naming conventions, which would be expanded to the pythonicly named class attributes on service_decode.
A simliar conflict exists if the service entry has an 'id' field, so if one exists, use it, otherwise generate one.
service_endpoint
is not abbreviated properly as it looking forserviceEndpoint
instead, soserivce_endpoint
gets added toextra
and when it is decoded, this constructor gets passes multiple parameters with the name 1service_endpoint`.https://github.com/sicpa-dlab/peer-did-python/blob/6bcfc4c8a282bc77ac2cea42fba558a0aa40da60/peerdid/core/peer_did_helper.py#L135
This change would abbreviate python and javascript naming conventions, which would be expanded to the pythonicly named class attributes on service_decode.
A simliar conflict exists if the service entry has an 'id' field, so if one exists, use it, otherwise generate one.