sid-am-ahd935 / Aliahns

This repository is under GDSC Aliah for their participants to get a good grasp of open source and how to work among others. In this repository there will be only beginner level contributions so as to get the participants started.
7 stars 25 forks source link

Added PasswordGenerator in Python #17

Closed haris-bit closed 2 years ago

haris-bit commented 2 years ago

Please accept this pull request for the hacktoberfest 2022

sid-am-ahd935 commented 2 years ago

You are halfway there @haris-bit. Our guidelines specify any Python contribution must be of more than 40 lines. You can try to add GUI in this program using tkinter or making it a CLI program using Argparse to make it eligible for submission.

haris-bit commented 2 years ago

ok, got it.

sid-am-ahd935 commented 2 years ago

Any updates @haris-bit ?

haris-bit commented 2 years ago

I wrote the code with tkinter but the lines aren't more than what's required.

On Sun, Oct 9, 2022 at 8:37 AM Aman Ahmed Siddiqui @.***> wrote:

Any updates @haris-bit https://github.com/haris-bit ?

— Reply to this email directly, view it on GitHub https://github.com/sid-am-ahd935/Aliahns/pull/17#issuecomment-1272446388, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOFJBDZZYGRB56LU3TRWNODWCI4YTANCNFSM6AAAAAAQ7VDGTU . You are receiving this because you were mentioned.Message ID: @.***>

haris-bit commented 2 years ago

It's only 30 lines of code

sid-am-ahd935 commented 2 years ago

Hi @haris-bit, just add your tkinter part of the code inside a function called "main" and then add:

And try to add something else, even suitable comments in the code is also appreciable. You are close to done.

haris-bit commented 2 years ago

ok, thanks will update in a couple of hours.

haris-bit commented 2 years ago

I'm creating a new pull request for updated version.

haris-bit commented 2 years ago

Thanks for helping me out, man. I really appreciate it 🙂

haris-bit commented 2 years ago

I might have to close this pull request in order to create a new one.