Closed GoogleCodeExporter closed 9 years ago
The code has a bug; it can access b->host after calling free_host(b).
Some more comments for the new function would help, e.g. explaining why. (The
bug
description is clear enough, but the code should have a similar explanation
too.
Future maintainers will be looking at the code, not at the bug description.)
Also, I would prefer more descriptive variable names, e.g. host1, host2, prev
rather
than a, b, p.
Otherwise, this looks fine.
Original comment by fergus.h...@gmail.com
on 8 Apr 2009 at 5:31
*slaps forehead*. Yep, missed that bug.
I took the hint for variable names from remove_service (which uses 'h' and
'p').
Changed to host1, host2, and prev.
Original comment by benizi
on 8 Apr 2009 at 6:29
Attachments:
Looks good to me now, thanks!
Do you want to go and and commit it?
I've made you a member of the "distcc" project, so you should have the right
permissions now.
(Please run "make check" first.)
Original comment by fergus.h...@gmail.com
on 8 Apr 2009 at 6:54
Fixed in SVN revision 673. Thanks!
Original comment by fergus.h...@gmail.com
on 14 Apr 2009 at 8:33
Original issue reported on code.google.com by
benizi
on 8 Apr 2009 at 5:14Attachments: