change dependency and add dev requirements file

sid5432 / pyOTDR

Simple OTDR SOR file parser written in Python

GNU General Public License v3.0

71 stars 28 forks source link

change dependency and add dev requirements file #7

Closed RemiDesgrange closed 4 years ago

RemiDesgrange commented 6 years ago

Right now, some dependencies are not used, like logging which is in the python std library.

I also add requirements-dev.txt for ease of dev.

I changed lazyxml to xmltodict because it's not well packaged and lazyxml cannot be pip install easily.

for robustness add argparse instead of manual argument parsing. I'm considering rewriting JSON/XML and status as Enum for robustness too, but I don't what are python plateform are targeted.

test are not passing right now, consider this PR as WIP, I'll fix text and squash ASAP

sid5432 commented 6 years ago

Sounds good. Thanks for the enhancement and fixes! I'll be busy with work for the next few weeks, so I might not get to it right away, but let me know when the tests pass.

RemiDesgrange commented 6 years ago

Ok, it's a problem with time. I think time repr.

E         -    ('date/time', 'Sat Jun 17 06:01:11 2006 (1150538471 sec)'),
E         ?                              ^^
E         +    ('date/time', 'Sat Jun 17 12:01:11 2006 (1150538471 sec)'),
E         ?

I have not idea how to deal with that but I will check on that. Maybe in a new pull request i'll look into making the date more "international" like 17/06/06 12:01:11 or maybe just timestamp :-)

RemiDesgrange commented 4 years ago

@sid5432 fiendly up :-) I'd like to have this merge before thinking about migration to python 3.

sid5432 commented 4 years ago

I just merged your changes. It looks like it broke all sorts of things :-( I'm kind of busy right now, so I'm not sure when I'll be able to get to it. Sorry.

RemiDesgrange commented 4 years ago

I'm going to fix it :-)