search

sid88in / serverless-appsync-plugin

serverless plugin for appsync
MIT License
951 stars 189 forks source link

feat: support MaxBatchSize #463

Closed vicary closed 2 years ago

vicary commented 2 years ago

It caught me by surprise that MaxBachSize is not supported.

My project recently reached a point where we are actively exploring ways to squeeze out the last bits of performances, batching is definitely something worth trying.

It is also allowed in Direct Lambda Resolvers, scroll down to the section Direct Lambda Resolvers: Batching enabled to read more.

bboure commented 2 years ago

LGTM! Thanks @vicary

Pipeline Functions also support this.

Could you please add it?

Also, not that we still need to solve this issue before we can release a new version. I will try to find some time to look into this again

vicary commented 2 years ago

@bboure Added support for Pipeline Resolvers!

Please take your time on the new major, hopefully a new direction takes shape when you're working on it.

Let me know when you have a new option syntax in your mind, I can help making a new PR for the new schema conversion.

bboure commented 2 years ago

@vicary Thanks! LGTM!

I took time to investigate the schema issue yesterday and left feedback on #453