search

sid88in / serverless-appsync-plugin

serverless plugin for appsync
MIT License
951 stars 189 forks source link

Support for associating an exising WAF #500

Closed rikhilrai closed 2 years ago

rikhilrai commented 2 years ago

Is it currently possible to associate an existing WAF ACL?

bboure commented 2 years ago

Thank you @rikhilrai

This is currently not supported but something we can consider adding in the future.

rikhilrai commented 2 years ago

Thanks @bboure Made a PR yesterday https://github.com/sid88in/serverless-appsync-plugin/pull/501. Would love to get your thoughts on it!

rikhilrai commented 2 years ago

Made a PR into alpha v2 as well: #504

rikhilrai commented 2 years ago

Hi @bboure, can we release this change in v1 of this plugin? Thanks in advance

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.14.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 2.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: