sid88in / serverless-appsync-plugin

serverless plugin for appsync
MIT License
951 stars 189 forks source link

feat(WAF): support associating WAF without creating #504

Closed rikhilrai closed 1 year ago

rikhilrai commented 2 years ago

closes #500

same as #501 but into v2 alpha base branch

bboure commented 2 years ago

Thank you. LGTM

One last thing. Would you mind also updating the doc? (on both PRs)

Thank you

rikhilrai commented 2 years ago

Absolutely! Added :)

rikhilrai commented 1 year ago

hey @bboure, thanks for your changes. PR LGTM!

bboure commented 1 year ago

👍 @rikhilrai

Sorry, I lost track of this PR and now I'm not sure what it does anymore. I'll dive back into it soon and prepare a merge + release

Thank you

bboure commented 1 year ago

Thanks!

I'll merge this now.

About doc, I have some new plans to improve it.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: