sid88in / serverless-appsync-plugin

serverless plugin for appsync
MIT License
951 stars 189 forks source link

Appsync custom domain name association fails intermittently #541

Open nvanlo opened 1 year ago

nvanlo commented 1 year ago

When a cloudformation stack contains more than 100 resources, the Appsync custom domain name association intermittently fails.

Command: sls appsync-domain assoc --stage xxx

Exception: image

Issue: index.js line 1860 describeStackResources only returns 100 resources (https://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_DescribeStackResources.html) We should instead use ListStackResources (https://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_ListStackResources.html)

Fix will be provided in a fork.

bboure commented 1 year ago

Sorry, I missed that, and the PR you opened 🤦

One teammate came across an issue today and we also found this issue was the cause of it. I also opened a PR #544

I solved this in a different way, please have a look, and let me know if it works for you.