search

sid88in / serverless-appsync-plugin

serverless plugin for appsync
MIT License
951 stars 189 forks source link

fix: make oidc clientId optional #599

Closed mogusbi-motech closed 1 year ago

mogusbi-motech commented 1 year ago

Documentation states that clientId is optional for OIDC, however, the validation in place makes it required. This PR fixes this by making clientId optional.

mogusbi-motech commented 1 year ago

@bboure @sid88in is there anything else that needs doing to get this reviewed and merged? This is currently blocking me from upgrading my apps to v2

bboure commented 1 year ago

Thank you @mogusbi-motech Sorry I missed your PR

This LGTM

thanks! 🎉

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: