search

sid88in / serverless-appsync-plugin

serverless plugin for appsync
MIT License
950 stars 186 forks source link

v2.3.0 Update Drops/Recreates API #607

Closed SethO closed 1 year ago

SethO commented 1 year ago

I just reproduced something I saw on one of my test APIs - updating this library to v2.3.0 will cause your API to be deleted/recreated. This gives it a new ApiId, URL, the works. I don't think this was intended. For any folks who are sharing the ApiId as a string/constant, this will wreck them.

image image

As a side note, my project with a Merged API was saved from this because, evidently, you cannot delete a source API if it is used by a Merged. That saved my bacon. image

bboure commented 1 year ago

Oh no! This isn't good.

I'm pretty sure it has been introduced by #604 I experienced the same behavior on one of my test APIs when I tested it, but I thought it was because I was switching from GLOBAL to PRIVATE and vice-versa.

I will try to confirm this issue and come up with a fix asap.

The problem might be that we should have kept undefined here when visibility is not specified

bboure commented 1 year ago

I was able to confirm this issue. #608 should fix it

Thank you for reporting this @SethO !

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 2.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: