search

sidataplus / omop-core

Part of OMOP NHSO TCELS project
0 stars 0 forks source link

Add OMOP Vocabulary supports #30

Closed ThanePi closed 1 year ago

ThanePi commented 1 year ago

Add and rework on some configuration to support Vocabulary in terms of omop also add some vocab constraint test case.

  1. omop-pg now include vocab schema and its DDL
  2. Now Trino catalog contains cdm and vocab instated of single omop
  3. Some test case
na399 commented 1 year ago

Hi @ThanePi ,

Why do we need to separate vocab from cdm?

ThanePi commented 1 year ago

Hi @ThanePi ,

Why do we need to separate vocab from cdm?

Hey @na399,

It's for scalability purposes, I found that most repo in OHDSI (such as ACHILLES used in ATLAS) have implemented parameterized schemas for "vocab", "cdm" and "result". Utilizing this should allows us for greater flexibility in further scaling (example: Having just single vocab server shared for all org, instated of each org ran their own vocab). Additionally, I believed that OHDSI team has divided their work into separate modules/teams to contribute to the overall OMOP project independently, this also for scaling purpose.

Another reason is that on early development of hosting ATLAS on SiData Warehouse, I also split OMOP DB into 3+ schema follows their permission by use case ("cdm" is read only, "vocab" is read only and write only for R server, "results" and "temp" are both read and write)

btw, We can discuss if this approach is match for our use case or to discuss further with our consultants.