search

siddhantgoel / beancount-dkb

Beancount Importers for DKB (Deutsche Kredit Bank) CSV Exports
MIT License
34 stars 13 forks source link

Add optional parameter existing_entries to extract() #87

Closed tbm closed 4 years ago

tbm commented 4 years ago

beancount/ingest/importer.py defines extract() as:

def extract(self, file, existing_entries=None):

... existing_entries: An optional list of existing directives loaded from the ledger which is intended to contain the extracted entries. This is only provided if the user provides them via a flag in the extractor program.

smart_importer's hooks pass existing_entries to extract() and the DKB importer fails because it doesn't recognize this optional argument.

siddhantgoel commented 4 years ago

@tbm thanks for both the PRs. I'll try to push an update on PyPI later this evening.

siddhantgoel commented 4 years ago

Just pushed v0.8.1 which includes this and the other PR.

tbm commented 4 years ago

Thank you Siddhant!