avoid commit on select queries

[WebDevelopNemanja]

On services where only fetching from database, commit it not necessary. Can you add some flag on context manager to avoid commit on that kind of session. I think that would be optimization.

[siddhantgoel]

Can you give me an example of how you're using it where you feel avoiding a commit would help?

[WebDevelopNemanja]

here is service: https://user-images.githubusercontent.com/4808609/66203689-426fde80-e6a9-11e9-9295-375ae5fffaac.png

here is raw log from sqlalchemy for that query: https://user-images.githubusercontent.com/4808609/66203737-5f0c1680-e6a9-11e9-89f6-fbb7a41c22b9.png

as you can see in the last line of log there is "commit" line, but database was not changed/updated with what service, just fetching.

[siddhantgoel]

Not sure if a flag is the right thing to do here. A better option would be to check if SQLAlchemy marked the session as dirty.

[WebDevelopNemanja]

Sure, it's better. So, am I connecting properly in that code snippet?

[siddhantgoel]

In your snippet, the session wouldn't be marked dirty. So if we were to add such a check, the commit wouldn't happen.

I still feel such a check (or a flag) is not necessary. Sounds like a micro optimisation. Unless you're noticing problems in your response times because of the final commit?

[WebDevelopNemanja]

Yes, it is micro-optimization, but we get 1 hit less to database :)

[siddhantgoel]

Sorry, but I'm hesitant about implementing optimizations without seeing numbers that prove otherwise :man_shrugging: